CORE-1977: fetch the time_limit_seconds from the DB for a job #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting to 72h, instead of using a hardcoded value
|
It's been several months and I didn't even remember what I did here, so I'm going to self-review and get this merged for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaulting to 72h, instead of using a hardcoded value of 72h for all jobs
I haven't been able to test this yet because of the QA environment being down, but I figured I could still put this up in case someone feels like looking/spots anything.
One thought I've had is that we should possibly change how the start date is calculated as well, because right now it won't account for any time spent waiting for a matching node from what I can determine. We'd need to instead find the earliest "Running" status and use its timestamp instead. That might be outside the purview of this ticket, though.